Repository navigation
Give each audio plugin instrument a volume and a mute - #5
Merged
Merged
Conversation
The lamp sat at the meter button's right edge, so a click on its right side, or one that moved a point while the button was down, fell outside the button and left the lamp lit. The button is padded around the lamp, and what follows each meter stands as far from it as before.
Each instrument's card in the audio plugins window has a speaker that mutes it and a volume slider, between its MIDI lamp and its meter, which now reads after the volume. They set Brack's gain and mute for the instrument, kept in the rack's session. They do not wait for Brack: the rack's contents are changed in place, without the save and refresh other changes make, so that a slider dragged while a plugin loads does not stall the window. The master volume above the seek bar gets a speaker too, for Brack's master mute. - While a volume slider is dragged, its tooltip shows the value (DragTip), and with Shift held it moves a tenth as far (FineDrag). Both take the pointer's input around the tooltip service and the slider, which would close the tip or put the value under the pointer. - The sliders' track sat 2 px high: the theme's rows around it did not add up to the slider's height. - A click on any meter puts out every clip lamp in the window. - Decibels holds the volume sliders' range and conversions, shared by the master and the instruments. - The tests' application has the Fluent theme, for the tests that drag controls. - Every window the main window opens (settings, port maps, audio plugins and the panes) opens again at startup if it was open when the player last closed, not only the panes. This needs Brack 2.0.0, with the instruments' volumes (its C API version 3), which BrackVersion now names.
hsshss
force-pushed
the
instrument-volume
branch
from
October 14, 2026 12:28
386f675 to
6865a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives each audio plugin instrument a volume and a mute, and the master volume a mute, with Brack's new instrument volumes; makes the volume sliders easier to set; and opens every window again that was open at the last close.
Volume and mute
Brack (hsshss/brack@0a7cbd2, C API version 3) gives each instrument a gain and a mute after its effects, and the master a mute. Both apply without waiting for Brack's thread and ramp, and a muted instrument goes on taking MIDI and playing, so that it is heard from where the song is when unmuted.
BrackRack.SetGain,SetMute,MasterMute).Decibelsholds the range and conversions both sliders share.The sliders
DragTip); with Shift held it moves a tenth as far (FineDrag). Both take the pointer's input around the tooltip service and the slider, which would close the tip or put the value under the pointer.Meters
Windows
Every window the main window opens (settings, port maps, audio plugins, and the panes as before) opens again at startup if it was open when the player last closed.
Brack package
CI and releases take Brack from nuget.org, at
BrackVersion1.2.0, which has no instrument volumes, so the build fails there until a Brack package with them is published andBrackVersiongoes up to it.Testing
dotnet test, 956 tests, with Brack beside: the volume and mute reach Brack and are kept, the master mute is kept, a drag keeps its tooltip open and moves a tenth as far with Shift without jumping, and a click on one meter clears the others.