Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Update Makefile & scripts from upstream - #38

Open
tkphd wants to merge 4 commits into
hpc-carpentry:gh-pagesfrom
tkphd:update-makefile
Open

Update Makefile & scripts from upstream#38
tkphd wants to merge 4 commits into
hpc-carpentry:gh-pagesfrom
tkphd:update-makefile

Conversation

@tkphd

@tkphd tkphd commented Mar 18, 2021

Copy link
Copy Markdown
Member

No description provided.

@bkmgit

bkmgit commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

When contributing, an assumption is made that the repository will be cloned onto the desktop. For lessons, many edits may be done in the browser without cloning to the desktop, so the wording can possibly be generalized and a link added to https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-and-deleting-branches-within-your-repository

Asking people to work on a branch and then make pull requests from the branch is helpful. See for example https://githubflow.github.io/

@tkphd

tkphd commented Mar 20, 2021

Copy link
Copy Markdown
Member Author

Completely agreed, @bkmgit. We should work these links into our Contributing guides, thanks!
Was this comment meant for #37?

@bkmgit

bkmgit commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

It does apply to #37 but description may also be useful in explaining how people can contribute.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants