feat(tables): add partition_by and sorted_by configuration - #156
Merged
Conversation
hotdata-automation
Bot
requested review from
anoop-narang
and removed request for
a team
August 3, 2026 10:24
| """ | ||
| One key of a table's sort order. Rows are written in this order, which keeps the values in each file within a narrow range and lets queries filtering on those columns skip files entirely. Most useful on columns you filter by ranges, such as a timestamp. | ||
| """ # noqa: E501 | ||
| column: StrictStr |
There was a problem hiding this comment.
super nit: column is the only field across the two new models without a description — TablePartitionKey.column has "Column the key reads.", and direction/nulls both have one. It surfaces as an empty Description cell in docs/TableSortKey.md line 9. Fix belongs upstream in the OpenAPI spec (hotdata-dev/www.hotdata.dev#292), not in this generated file. (not blocking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/292