ci: add a Uniswap v4 hook risk check - #3
Open
chaosxcode wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one workflow that runs HookGuard on every pull request.
What it does. It looks for a specific set of Uniswap v4 mistakes and comments on the exact line when it finds one — callbacks any address can call, hooks keeping per-pool state without checking which pool is calling, dynamic fees with no ceiling. Every rule traces to published guidance (Trail of Bits' v4 hooks paper, Uniswap's security framework) or to the Bunni v2 and Cork post-mortems.
On this repo specifically. It picks up
LaunchHookin this repo and currently flags nothing. I'd rather show you that than invent a problem — the value is that it stays quiet unless something changes.It can't block you.
fail-on: nevermeans annotations only. Drop that line if you'd rather it gate on serious findings.Straight about the limits. Heuristic pattern matching, not an audit. It reads permissions and source patterns, not what your hook actually does. A flag means worth a look, never broken; silence means nothing matched at this level, never safe.
I tested it against 272 real deployed hooks and wrote up the five ways it was wrong, plus what I changed. Just over half of real hooks come back clean.
Close it without a second thought if you'd rather not take on a dependency.