Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400
Description
In
responseViaCache, whenheaderis a plain object and noContent-Lengthwas specified,header['Content-Length'] = ...mutated the caller's header object in place.If that header object is reused across responses (e.g., a module-level constant) or frozen via
Object.freeze(...):TypeError: v is not iterable(HTTP 500) because Hono's response handler iterates non-string values as multi-value headers.TypeError: Cannot add property Content-Length, object is not extensible(HTTP 500).Solution
Instead of mutating the incoming
headerobject in place, create a shallow copy withContent-Lengthonly when it needs to be injected:Tests
string,Uint8Array, andBlobbodies to ensure caller header objects remain unmodified across sequential requests.Object.freeze) do not cause runtime errors.