Skip to content

🌱 test(cli): pin the ls alias mention in help output - #468

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:mainfrom
Karibhou:test/467-help-ls-alias
Nov 2, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:mainfrom
Karibhou:test/467-help-ls-alias

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Since #466, src/cli.ts prints (alias: ls) on the rationguard sessions line of HELP, and the ls switch case is covered, but no test in describe('help') asserted the help text mentions the alias. This adds one assertion so the documentation cannot silently drift from the command surface.

  • src/cli.test.ts: new documents the ls alias on the sessions line test matching rationguard sessions (alias: ls) in stripped help output.

Test-only change, so no CHANGELOG entry (shipped code untouched).

Verification: npm run lint, npm run build, npm test (478 pass, 0 fail). Mutating dist/cli.js to print (aka: ls) makes the new test fail.

Closes #467

— hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: d7d6024

src/cli.ts prints '(alias: ls)' on the sessions line of HELP since hivecommons#466, but
no help test asserted it, so the documentation could regress silently.

Hive-Run: hivecommons#467
Hive-Plan: review-backlog/style
Hive-Spec: rationguard-cli-help#alias-ls
Signed-off-by: Karibhou <[email protected]>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 2, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Checked against the tree at d7d6024: src/cli.ts:64 renders ${ANSI_CYAN}rationguard sessions${ANSI_RESET} (alias: ${ANSI_CYAN}ls${ANSI_RESET}), and stripAnsi (src/cli.test.ts:63) strips exactly the \x1b[...m sequences, leaving rationguard sessions (alias: ls) — which the new regex at src/cli.test.ts:111 matches. The help path (src/cli.ts:612) is the one run(['help']) exercises. Ran node --test dist/cli.test.js at the PR head: the new assertion passes alongside the existing ls alias works with --json test. Test-only, so skipping the CHANGELOG is consistent with the repo's changelog-guard (green).

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 9ee4d75 into hivecommons:main Nov 2, 2026
16 of 17 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#468d7d6024` sha256:a632a39ba92fed3bba5cfb5696dbda77230a6b64dd122c2a01b7c0f411a0c43e — download from the dashboard or `hivectl review evidence #468`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (style): Help text does not have a test pinning the new alias mention

1 participant