Repository navigation
fix: keep the Integrations link on-site when syncing Hive docs - #553
Conversation
The sync's Case 2 rewrite pushed the Hive intro's Integrations link to GitHub because localHiveDocs — which exists exactly for locally authored pages — was empty. Adding integrations.md to localHiveDocs ensures the canonical published route /docs/hive/integrations is linked instead.
Adds unit tests asserting rewriteLinkTarget('integrations.md', ...) returns the internal route from both README and landscape.md sources.
Regenerates the affected synced pages (readme.md, documentation-map.md, landscape.md) with the corrected links.
Closes #552
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs canceled.
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#5533fda32d` sha256:63f763d9097ba39d7b2ae87c8e90b4fd91c437f3e54b72de189b8d623d2deca8 — download from the dashboard or `hivectl review evidence #553`. |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read scripts/sync-hive-docs.ts at merge-base and on this head. Looks correct to me.
One note on mechanism, for whoever maintains the sync: syncedRepoPaths (sync-hive-docs.ts:155) is built from files only, so integrations.md does not hit Case 1 by exact path. It resolves through the Case 1b basename fallback (basenameToSiteRoute, built from [...files, ...localHiveDocs] at :170–177), which is exactly the path localHiveDocs was added for — so the fix lands where intended, and main() still iterates files only, so the locally authored docs/content/hive/integrations.md is never overwritten by the sync.
Verified:
/docs/hive/integrationsexists (docs/content/hive/integrations.md) and is already linked fromintegration-guide.md,work-sources.md,running-at-level-6.md; "Check internal doc links" is green.npx vitest run scripts/sync-hive-docs.test.ts→ 36 passed on this head; the two new assertions fail without thelocalHiveDocsentry (fallback returnsundefined→ Case 2 GitHub URL).- The remaining
integrations/forges.mdlink inlandscape.md:232stays on GitHub, correctly — that page is neither synced nor authored here. - Regenerated pages match what the script produces; no unrelated changes.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive
Bot
removed
role/trusted
The sync's Case 2 rewrite pushed the Hive intro's Integrations link to GitHub because
localHiveDocs— which exists exactly for locally authored pages — was empty.Adding
integrations.mdtolocalHiveDocsensures the canonical published route /docs/hive/integrations is linked instead of the GitHub copy in src/docs/integrations.md.Test added:
rewriteLinkTarget('integrations.md', README)correctly returns "/docs/hive/integrations"rewriteLinkTarget('integrations.md', 'src/docs/landscape.md')correctly returns "/docs/hive/integrations"Files regenerated with corrected links:
Closes #552
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88