Message buffer ordering and dedup - #133
Open
Jokler wants to merge 3 commits into
Open
Conversation
zealsprince
approved these changes
Aug 17, 2026
zealsprince
left a comment
zealsprince
left a comment
Member
There was a problem hiding this comment.
I reviewed most of the changes but haven't put my stamp of approval on until I'm back in office next week.
If you want to merge it to unblock yourself for a next step feel free and I'll do a follow up when I'm back. Otherwise I'll do a review of the remainder later! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory messages would have been ordered and deduped already but the insert logic was missing in a lot of places. I used this opportunity to replace the message
OrderMapwith a database interface which is backed byIndexedDBin WASM. As a result this PR mostly acts as a first iteration of a persistent storage solution.The mock test gets dragged along but still just acts as a POC instead of really testing anything.
Closes #34.