Skip to content

HPI-22144 IAM-10624 IAM-10636 AAA auth Java SDK — Support resource pa…#165

Open
spaltis wants to merge 2 commits into
masterfrom
IAM-10636
Open

HPI-22144 IAM-10624 IAM-10636 AAA auth Java SDK — Support resource pa…#165
spaltis wants to merge 2 commits into
masterfrom
IAM-10636

Conversation

@spaltis

@spaltis spaltis commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

…rameter in client_credentials token requests

…rameter in client_credentials token requests

Signed-off-by: Stanislav Paltis <[email protected]>
@spaltis spaltis self-assigned this Jul 27, 2026
addFormParam(formParams, GRANT_TYPE_FORM, getGrantType());
addFormParam(formParams, EXPIRES_IN_FORM, getExpiresIn());
addFormParam(formParams, SCOPE_FORM, getScope());
addFormParams(formParams, "resource", resource);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using getter here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

.setExpiresIn(request.getExpiresIn())
.setScope(request.getScope());
.setScope(request.getScope())
.setResource(request.getResource());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since resource is optional what will happen here if original request doesn't have resource?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment

…rameter in client_credentials token requests

Signed-off-by: Stanislav Paltis <[email protected]>

@rajdoshi07 rajdoshi07 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants