Skip to content

Move player editing into a dialog, rework the mobile tabs, and add animations - #2

Merged
hendrikmelse merged 1 commit into
masterfrom
edit-players-dialog-and-mobile-tabs
Nov 6, 2026
Merged

hendrikmelse merged 1 commit into
masterfrom
edit-players-dialog-and-mobile-tabs

Conversation

@hendrikmelse

Copy link
Copy Markdown
Owner

Summary

  • Editing players now happens in its own modal. The player list card is display-only. On touch screens the keyboard stays up while the modal is open, and the modal only moves out of its way when it would be covered (and stays there when the keyboard goes).
  • Header: Home, Edit players and fullscreen are in one row, which frees up room for the player list.
  • Game title is removed from the UI (it stays in the data model). Starting a new game no longer shows an undo toast.
  • Color picker: same layout on desktop as on phones, centered on the swatch it is for, with a Done button on phones.
  • Mobile tabs: pressing the selected tab shows the player list on its own (its own "no tab selected" state, showing total scores). The table takes the list's room. Tabs slide, drop and resize with animation, in the direction they are moving.
  • Player list: scrolls smoothly to center the active player, the round heading and scores slide when the round changes, and a score bounces when it is saved.
  • Keypad: keys show their press animation for keyboard input.
  • Also a favicon, and a "While iterating" note in CLAUDE.md.

Test plan

  • npm run lint, format:check, typecheck, test (327 tests) and build pass
  • Try the edit dialog on a phone: keyboard stays up, tapping a name puts the cursor in it without selecting, the dialog stays clear of the keyboard
  • Try the mobile tab animations (slide up, drop, the card growing for the table, pressing the selected tab) on a phone
  • Check the desktop layout: header row, tab slide-in, color picker position

The animations and keyboard behavior are not covered by the tests, as jsdom cannot show them.

🤖 Generated with Claude Code

…imations

- Remove the game title from the UI (it stays in the data model).
- Add a favicon.
- Put Home, Edit players and fullscreen in one row in the header.
- Edit players now happens in its own modal; the player list card is
  display-only. The modal keeps the keyboard up on touch screens and
  moves clear of it only when needed.
- Remove the toast for undoing a new game.
- Color picker: same layout as on phones, centered on its swatch, with a
  Done button on phones.
- Mobile tabs: pressing the selected tab shows only the player list (its own
  "no tab selected" state, with the total scores), the table takes the list's
  room, and tabs slide, drop and resize with animation.
- Player list: centers and smoothly scrolls to the active player, slides the
  round heading and scores on round changes, and bounces a score when saved.
- Keypad keys show their press animation for keyboard input.
- Table hint says "click" as it is only shown on desktop.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@hendrikmelse
hendrikmelse merged commit 16b5418 into master Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant