Repository navigation
docs: record three things that lived only in a conversation - #51
Merged
Merged
Conversation
- architecture-beta edge labels cannot be written: the AST carries a title, the shipped grammar has no token for one. The readme stops calling that support "full", and the code path that would place such a label says it is unreachable until the parser is bumped - No regression fixture for the collision that label could cause: a test whose source cannot parse proves nothing - The stylesheet saving is about half the byte arithmetic on an RSC build, since the framework emits every element twice. Written next to the claim it bounds - CONTRIBUTING now explains why only verify and sites are required checks. Requiring `check` would block every version pull request, and `build` has a paths filter so it may never report at all - Roadmap loses its version numbers, which went stale when 0.3 shipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four write-downs. Each one is information that existed nowhere in the repository, which is the only reason any of them is worth a commit.
1.
architecture-betaedge labels cannot be writtenI set out to add a
regressionsfixture for a collision I had claimed — an architecture edge label sitting on a route's corner and landing on a node. It does not reproduce, and finding out why was the useful part:@mermaid-js/[email protected]publishes anEdgeAST with atitlefield.ARCH_TITLEtoken at all — checked in the bundled chunk, not inferred. Every candidate syntax is a parse error.developbranch has since added'-' title '-'to the arrow rule, so this starts working on a parser bump, not on a change here.So the readme stops calling that support "full", and
edgeLabel()says it is unreachable and why. No fixture: a regression test whose source cannot parse proves nothing, and would have looked like coverage.2. The stylesheet saving is about half the arithmetic on an RSC build
Next.js emits every element twice — once as HTML, once in the RSC payload — so a saved copy is still counted once in each. Recorded next to the claim it bounds, with the measurement: four diagrams, 227.9 kB to 202.1 kB, where removing four inlined copies outright would have been nearer 52 kB.
3. Why only two checks are required on
mainCONTRIBUTING.mdnow explains the protection, because the failure mode is silent and total — a pull request that can never merge, with nothing on the page saying why:checkskips itself forchangeset-release/mainand#skip-changeset, so requiring it blocks every version pull request.buildhas apathsfilter, so it may never report at all.enforce_adminsoff so the owner cannot lock themselves out; linear history not required because every merge here is a merge commit.4. The roadmap had two
0.3entriesMine, from the previous pull request. Now unnumbered — the numbers went stale the moment
0.3shipped.On the changeset
There is one,
patch, and I checked rather than assumed. The only source change is a comment, but Vite builds this package withminify: false, so the comment lands indist/index.jsand the tarball genuinely differs from the published0.3.0— verified by diffing the built tree against the published one, file by file. The entry says the thing a consumer cares about: edge labels are unavailable, and why.