fix(ci): repair non-app-server Rust lint failures - #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The full Rust CI matrix on
2968352abd33e7bf6e6a3fd1024b52fd481299daexposed mechanical lint failures outside the concurrently owned app-server and goal-runtime files: argument comments on opaque positional literals, three Rust 1.97 macOS formatting borrows, and Windows-only dead-code diagnostics for Unix policy material.What changed
/*param_name*/comments reported by argument-comment-lint outsidecodex-rs/app-server/**andcodex-rs/state/src/runtime/goals.rs.Path::display()in the macOS seatbelt assertions.cfg(test).Verification
just argument-comment-lint: only the 11 concurrently ownedcodex-rs/state/src/runtime/goals.rsdiagnostics remain.just check-fast -p codex-corejust test-fast -p codex-core tools::policy::tests(23 passed)just test-fast -p codex-sandboxing(50 passed)The local Windows target check could not reach
codex-corebecause this Linux host lacksx86_64-w64-mingw32-gcc; the native Windows matrix remains the proof gate for that cfg path.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.