Support GHC 9.12 MultilineStrings - #1893
Merged
Merged
Conversation
haskell-lexeme-looking-at-string-literal is now a dispatcher into haskell-lexeme--scan-string-literal, which scans a literal delimited by any number of double quotes, terminated or not by newlines.
Collaborator
|
Looks good. |
Member
|
Thanks, merged! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1877.
This fixes the syntax highlighting and the indentation. Recognition is not conditional on the extension being used, the same way quasi-quotes are treated.
When it recognizes either
"""or",haskell-lexeme-looking-at-string-literaldispatches into a general scanner,haskell-lexeme--scan-string-literal, parameterized by the number of quotes (1 or 3) and by whether an unescaped newline should terminate the literal.haskell-syntax-propertizemarks the extra delimiter quotes and any quotes inside the literal as punctuation, so the syntax parser sees one ordinary string spanning lines.