Pass --skip to HashcatStatus for newer versions - #74
Open
MelvinFrederiks wants to merge 4 commits into
Open
Conversation
If get_progress or get_progress_total is called with absolute=True, add the skip amount to the result. This restores behaviour desired in hashcat/hashcat#4805
Also move version threshold to 7.2
Author
|
Maybe this is not necessary, as we could use CURKU instead of PROGRESS field to get the absolute position in the search space? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in hashcat/hashcat#4805, the --machine-readable PROGRESS format has changed to not include the --skip amount anymore.
This fix ensures that the old functionality is preserved for applications querying these progress (current & total) fields.