Repository navigation
Conversation
lunelson
added this pull request to stack #10068
October 19, 2026 16:56
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
lunelson
force-pushed
the
ln/fe-1851-ledger-comments
branch
from
October 19, 2026 19:10
c62379e to
ec5481a
Compare
Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
… in reopened transcripts Co-authored-by: Cursor <[email protected]>
…n the reopened chat Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
lunelson
force-pushed
the
ln/fe-1851-ledger-comments
branch
from
October 19, 2026 21:44
ec5481a to
9e0e9e7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Users can comment on Ledger records. Brunch reads the comments on its next turn, corrects the Ledger or asks about them, and the comments are resolved once a commit addresses them.
🔗 Related links
🚫 Blocked by
🔍 What does this change?
brunch.ledger-comments, rendered to the model as an XML block. Each comment names the records it is on by address, keeps the selected text for display, and has an ID such asn1.foldCommitsholds comments inLedgerState.commentsand treats a comment signal as a turn: later commits are anchored to it, andexchangescounts it.resolves: [commentId]; an unknown ID is refused. Receipts andledger_compilelist the comments still open, and the system prompt asks Brunch to address every comment.@local/flue-aisdk-transportcan deliver a host-derived signal instead of a user message, and a reopened transcript shows host-named signals as user turns.Pending comments are kept in memory per editor, so a reload drops unsent ones.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
@hashintel/brunch-agent,@local/flue-aisdk-transport). No changeset.📜 Does this require a change to the docs?
libs/@hashintel/petrinaut/docs/ai-assistant.md("Ledger in Brunch") needs a paragraph on commenting. This stack doesn't touch the Petrinaut packages, so it follows separately.🕸️ Does this require a change to the Turbo Graph?
🛡 What tests cover this?
resolves, refusal of unknown comments, open comments on receipts and in the Markdown map.ledger-history.integration.tssends a comment through the real Flue runtime and checks that the model receives it, the commit is anchored to it, andresolvesclears it.❓ How to test this?
yarn dev:brunch, open a Brunch construction conversation and let Brunch record something.