Repository navigation
BE-930: Add memory, thread and disk limits to the workspace - #10003
thehabbos007 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## asa/hash-integrations/04a-engine-snapshots #10003 +/- ##
==============================================================================
+ Coverage 68.29% 68.30% +0.01%
==============================================================================
Files 2003 2004 +1
Lines 205815 205892 +77
Branches 8739 8746 +7
==============================================================================
+ Hits 140568 140643 +75
- Misses 63565 63566 +1
- Partials 1682 1683 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b241522 to
8f8ddc7
Compare
8f8ddc7 to
fe46e4a
Compare
fe46e4a to
29f3584
Compare
29f3584 to
9812312
Compare
9812312 to
0f8278e
Compare
0f8278e to
e28208b
Compare
PR SummaryMedium Risk Overview Introduces an optional Integration tests cover applied DuckDB settings, open refusal when already over limit, post- Reviewed by Cursor Bugbot for commit 1a598d5. Bugbot is set up for automated code reviews on this repo. Configure here. |
e28208b to
3c8acb8
Compare
3c8acb8 to
100b5ef
Compare
100b5ef to
1a598d5
Compare
🌟 Purpose
This PR lets a caller limit a workspace's memory, threads and disk use through
WorkspaceConfig.🔍 Changes
memory_limit,temp_directory_limitandthreadsset DuckDB'smemory_limit,max_temp_directory_sizeandthreadssettings.disk_limitlimits the combined size of the database file, its log and DuckDB's temporary directory. The workspace checks it on open and after eachqueryandcreate_table. When the files are over the limit, it checkpoints the log into the database file and measures again before it fails withDiskLimit.create_tablecan write past the limit, and the table it created stays in the database.