Repository navigation
fix(directives): read directives_path; inspect warns when it is missing - #120
Draft
aarontrowbridge wants to merge 1 commit into
Draft
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
Contributor
Author
|
Left as draft deliberately: this PR conflicts with night draft #116 (per-root field mapping) in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
directives_pathwas parsed and displayed byarjev inspectbut never read.load_directivesnow resolves, in order:$ARJEV_DIRECTIVES_FILE, thendirectives_path, thenarjev-directives.mdat the first root that has one. With neither set, behavior is unchanged.arjev inspectreports a set-but-missingdirectives_pathas an advisorywarning:line (counted infold warnings). It is deliberately not ablocked:line:inspect's blocking set is documented as closed (no feeds / no roots / zero identity-bearing notes) and the loader degrades to empty rather than failing. Easy to flip to blocking if preferred.Evidence
tests/test_directives_path.py(9 tests); 5 failed before the fix.pytest: 295 passed.ruff check .: clean.docs/agent-setup.md, entry under Unreleased inCHANGELOG.md.Note: an
ARJEV_DIRECTIVES_FILEthat is set but missing still yields empty without fall-through (existing behavior;inspectdoes not warn about it).