Repository navigation
fix(render): drop doubled mode: prefix in vault note frontmatter - #119
Open
aarontrowbridge wants to merge 1 commit into
Open
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
aarontrowbridge
marked this pull request as ready for review
October 31, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
render_vault_notewrotemode: {mode}into frontmatter, butmodeis the composite line frommode_line()and already carries its ownmode:prefix, so the note readmode: mode: jev, ok(invalid YAML). The frontmatter now strips that prefix.mode_line(), the note body, the Slack header and stdout are unchanged.Evidence
tests/test_vault_note.pyparses the written frontmatter withyaml.safe_load; reverting the fix makes it fail withScannerError: mapping values are not allowed here, restoring it passes.pytest: 287 passed.ruff check .: clean.tests/fixtures/vault/digests/2026-10-01.mdis regenerated by the e2e tests on every run and carried the same bug; it is updated to match.Not in this PR: digests already written to real vaults (e.g. a 2026-10-31 digest) stay invalid, since arJev never edits existing notes. Those need a one-time manual fix.