Repository navigation
feat(agents): Method sections and dispatch on four cast cards so Amicissimo overlays can merge (#2118) - #2119
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2118. Part of the Amicissimo release (ledger session-20261102-amicode-system-v2 §3e).
The overlay loader merges only into cards with
dispatch:and a## Methodsection with four anchors; before this PR only librarian.md had both, so entitled overlays for the other four cast roles would have thrown "base card lacks the anchor" and the install would have silently got the base card alone.dispatch: <role>-tuning+ a complete default in each dimension. The numbered procedure moved verbatim intoDefault procedure; the hard Rules now sit ABOVE## Method, so an overlay can replace the procedure but never the rules. Routing text unchanged apart from suggested -> default.steps:, permissions, the Return contract are untouched.card_overlay_merge.test.ts(26 tests): for each of the five dispatching cards, a four-field overlay merges with no throw and leaves frontmatter, permissions and the receipt section byte-identical; interface-class and unclassified fields throw; the empty overlay is a no-op; every anchor carries non-empty default text. Critic has no dispatch.Needs a human check:
.seed-provenance.jsonamendment 4 recordsaaron via harmoniqs/amicode#2118. The integrity tests require a non-empty signer; approving this PR is that sign-off. Also check the implementer card's five-step default: steps 1, 3, 4, 5 restate its existing hard rules, no new behaviour.