Repository navigation
feat(i18n): add Simplified Chinese for the macOS app UI - #9
Open
REMIXPLAYER wants to merge 3 commits into
Open
REMIXPLAYER wants to merge 3 commits into
REMIXPLAYER wants to merge 3 commits into
Conversation
Wire user-visible String values through a small L10n helper and ship zh-Hans Localizable/InfoPlist strings so the menu bar app follows the system language. English remains the source keys and development region.
…and locked permissions. English UI copy only: shorten the Automatic and As needed resource blurbs, expand the phone/cellular hardware banner so Messages is covered, and make the locked-permission help say the control cannot be changed. zh-Hans values are unchanged; keys are renamed to match.
Author
|
Two follow-ups I’d like your take on (not in this PR):
Happy to follow your preference. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Simplified Chinese (
zh-Hans) for the macOS menu-bar app. When the Mac language is 简体中文, settings, notices, status, privacy, and setup/install copy follow the system language.English remains the source keys and
CFBundleDevelopmentRegion. User-visible strings go through a smallL10nhelper;zh-HansLocalizable.strings/InfoPlist.stringsare registered inproject.yml.Scope
In scope: host app UI (settings, notices, status, privacy categories, setup/install prompts, microphone usage description, and user-visible errors).
Out of scope: Android guest locale inside the VM, AppHost localization, README/website copy, and keeping translation catalogs (csv/md) in-tree.
Commits
zh-Hansstrings (English source keys unchanged).Follow-up (not in this PR)
No in-app language switch — the host UI follows the Mac system language. A later change could detect that language and pass it through to the Android VM locale; that is intentionally out of scope here.
Validation