Repository navigation
Simplify SQLite storage lifecycle - #172
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 636f0acdc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the RSS SQLite storage lifecycle by removing automatic snapshots,
startup consistency scans, snapshot restoration, and corruption-triggered
database replacement.
Motivation
SQLite is more resilient than the previous lifecycle assumed.
SQLite already provides transaction and crash-recovery guarantees. The
existing WAL journal mode and synchronous=FULL configuration provide a
sound durability baseline. Maintaining an additional backup and recovery
subsystem adds complexity beyond what normal database operation requires.
Independent scheduled backups can interfere with Halo's backups.
The plugin's snapshot creation and rotation can overlap with Halo's own
backup tasks, introducing competing I/O and changes to files being backed
up. Removing the separate schedule reduces coordination problems between
the plugin and the host application.
Automatic restoration does not match user expectations.
A database error should not implicitly authorize rolling data back to an
older snapshot or replacing it with an empty database. These actions can
unexpectedly discard reading progress, favorites, and other saved state.
Preserving the existing files and reporting the failure leaves recovery
decisions with the user.
Halo's built-in backup workflow should be authoritative.
Users should manage backups and restoration through Halo's built-in
functionality. The plugin should not maintain a separate backup schedule,
retention policy, or automatic restoration policy.
Behavior changes
start. RSS storage becomes unavailable while link management remains usable.
cleanup.
database with legacy data.
Validation
snapshots are not restored automatically, and manual restoration works.
and link queries.