Repository navigation
Fix Jackson classloader conflicts in dependent plugins - #168
Merged
Merged
Conversation
Co-Authored-By: Claude Code <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5da80fc9aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled Jackson classes in PluginLinks can cause a
LinkageErrorwhen a dependent plugin accesses Halo's Jackson APIs. Exclude the transitivecom.fasterxml.jackson.coredependencies fromnitrite-supportso Jackson is provided by Halo.Fixes #167
Reproduced with the official PluginLinks 2.3.0 JAR, Halo API 2.25.0, and PF4J 3.15.0 in a minimal classloader harness. A plugin classloader declaring a dependency on PluginLinks fails when calling either
JsonUtils.mapper().convertValue(...)orUnstructured.OBJECT_MAPPER.convertValue(...), with a loader constraint violation forObjectMapper. Both calls succeed with the rebuilt JAR after this change. A full Halo 2.26.1 integration test was not performed.Validation:
./gradlew buildpassed: 369 backend tests and 171 frontend tests, including 13 Nitrite migration tests.runtimeClasspathno longer containscom.fasterxml.jackson.coredependencies.com/fasterxml/jackson/**entries and retains the Nitrite importer.🤖 Generated with Claude Code