Skip to content

fix: initialize each gallery container only once - #34

Closed
LIlGG wants to merge 3 commits into
halo-sigs:mainfrom
LIlGG:feat/fix-gallery-event-binding
Closed

LIlGG wants to merge 3 commits into
halo-sigs:mainfrom
LIlGG:feat/fix-gallery-event-binding

Conversation

@LIlGG

@LIlGG LIlGG commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

已汇总至 #38,本 PR 关闭并由其替代。

What this PR does / why we need it:

合并旧配置和页面规则,只注入一组资源。先准备图片再按容器初始化,并跳过已有实例,避免重复绑定。

处理器行为测试通过。内置浏览器同时配置旧选择器和相同规则,3 张图片各只有 1 个点击监听器,两个区域分别显示 2 张和 1 张图片。集成测试共 16 项通过。

依赖 #32:本分支已同步其完整基线提交,可独立执行 CI。建议先合并 #32;在此之前 Files changed 会包含公共基线,审核功能改动可比较 feat/update-halo-build-baseline 与本分支。本分支已单独通过 ./gradlew clean build,并检查 JAR 静态资源。

Which issue(s) this PR fixes:

无。代码及运行时确认的重复初始化缺陷。

Does this PR introduce a user-facing change?

减少灯箱重复初始化和重复点击事件绑定。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant