Skip to content

Support custom categories for plugin-contributed MCP tools - #15

Merged
ruibaby merged 3 commits into
mainfrom
feat/provider-tool-categories
Oct 10, 2026
Merged

ruibaby merged 3 commits into
mainfrom
feat/provider-tool-categories

Conversation

@ruibaby

@ruibaby ruibaby commented Oct 10, 2026

Copy link
Copy Markdown
Member

Summary

Plugin-contributed tools currently all appear under the fixed PLUGIN category, preventing providers from organizing larger tool sets by business area. Add McpToolDefinition.Builder.category(String) and pass the category through to the Console tool catalog so the existing tool catalog and access-key selector can group tools by plugin and then category.

Omitted, empty, or whitespace-only categories default to PLUGIN; custom categories are trimmed and can use localized names. Document the API and add regression coverage for category defaults, normalization, catalog mapping, and grouping across plugins.

This change only affects management UI grouping. MCP protocol tool names, input/output schemas, authentication, and per-tool allowlists remain unchanged. Providers using the new builder method need an API artifact and MCP Server version containing this change.

Validation

  • Java 21: ./gradlew --offline build passed (161 backend tests).
  • Java 21: CI=true ./gradlew --offline :ui:check passed, including formatting, lint, type checking, and 38 tests across 13 files.
  • git diff --check passed.

Offline mode was used because Maven metadata requests returned HTTP 403; dependencies were already cached. Console grouping is covered by unit tests; the updated server has not been deployed for a browser smoke test.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T14:02:15.894447Z b195f88 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e93def020d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/java/run/halo/mcpserver/McpToolCatalog.java

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c41a741cb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/src/main/java/run/halo/mcpserver/api/McpToolDefinition.java
@ruibaby
ruibaby merged commit 71fea08 into main Oct 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant