Repository navigation
Export the deployment URL once, for every step that needs it - #50
Merged
Merged
Conversation
The kill leg shells out to docker compose, and the compose file interpolates ONELIGHT_SERVER_URL. The exercise step did not set it, so run 16 failed there immediately -- after setup, upload, transcode, every rendition, the watermark burn and the HDR tonemap had all passed against the real deployment. That is the third step to be caught by the same missing variable: the logs step, the teardown, and now the exercise. Setting it per-step is the kind of thing that will keep being forgotten, so it is written to GITHUB_ENV beside CI_URL and every later step has it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 16 passed everything it was testing and then failed on a missing environment variable.
The kill leg shells out to
docker composeto find and kill the worker that is mid-encode, and the compose file interpolatesONELIGHT_SERVER_URL. The exercise step never set it.Third step caught by the same variable: the logs step, the teardown, and now the exercise. Setting it per-step is the kind of thing that keeps being forgotten, so it goes into
GITHUB_ENVbesideCI_URLand every later step has it. The per-step copies are removed.Worth recording what this run proved before it fell over: setup, multipart upload, probe, transcode, all eight renditions, proxy colorimetry, Range serving, comments, shares, the watermark burn retaining BT.709 and tmcd, and an HDR PQ source tonemapped to a BT.709 proxy with libplacebo running inside the worker container — all against a real Workers/D1/R2 deployment.