Repository navigation
Let the exercise skip a leg the target cannot run - #49
Merged
Merged
Conversation
Run 15 got the whole media path working on a real Cloudflare deployment: the watermark burned, kept its BT.709 tags and source timecode, and the clean and burned renditions differ. Then it stopped on the marker export, which that target cannot do. Exports are node-only and not by oversight. The PDF report reads its font with node:fs, and the annotation compositor is sharp, a native module, so the export module cannot be loaded in an isolate at all -- and wrangler bundles dynamic imports, so deferring the import does not avoid it either. Making exports work there means the font as bytes and a compositor that is not sharp, which is real work and is tracked on its own. It is also not what this run exists to prove. The acceptance criterion is that a worker killed mid-encode has its job finished by another and the rendition plays, and blocking on an unrelated feature gap means never reaching it. So the exercise takes a flag, the acceptance run sets it, and the docker integration job does not: exports stay fully covered where they are supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 15 got the entire media path working on a real Cloudflare deployment:
Then it stopped on the marker export, which that target cannot do.
Why exports are node-only, and not fixable in passing
pdf-report.tsreads its font withnode:fsannotation-svg.tscomposites with sharp, a native moduleSo the export module cannot be loaded in an isolate at all — and wrangler bundles dynamic imports, so deferring the import does not avoid it. Making exports work there means embedding the font as bytes and replacing sharp with something that runs in a Worker. That is real work, tracked separately, and #47 already records it in
apps/cf/src/index.ts.Why skipping is the right call rather than a dodge
The acceptance criterion for P0-2 is specific: CI uploads through the real deployment, kills the first worker attempt, the job is retried on another worker, and the resulting rendition plays. Blocking on an unrelated feature gap means never reaching it.
So the exercise takes
ONELIGHT_E2E_SKIP_EXPORTS, the acceptance run sets it, and the docker integration job does not — exports stay fully covered on the target that supports them, which is the one you actually run.The skip logs itself rather than passing silently, so a run that skips it says so.