Repository navigation
fix(lut): preserve HDR highlights at full brightness (1.9.1) - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Gamma 2.2 and 2.4 compressed HDR highlights at 100% brightness because the headroom blend started from a clamped SDR-white value. At 200-nit SDR white, the old math mapped a 1,000-nit input to approximately 364 nits.
Preserve the headroom target's full signal range and fade only the correction at SDR white. Gamma alone now passes through every HDR LUT sample above SDR white; brightness alone follows the requested dimming curve. Apply the same correction to the measured-response LUT path. Update the comparison renderer, whitepaper equation, release notes, and version to 1.9.1.
Checklist
dotnet test src/Gloam.sln -c Releasepasses: 1,351 tests.dotnet build src/Gloam.sln -c Release -p:GloamStrictBuild=trueis warning-free.src/Gloam.Corehave tests.Calibration math
Regression coverage includes gamma 2.2/2.4, SDR white levels from 80 to 1,000 nits, measured-response LUTs, linear and perceptual dimming, shadow-only controls, and exact identity entries after 256-entry/16-bit hardware-ramp conversion. Existing night-mode boost and continuity tests pass.
What was measured? Generated LUT signals and the hardware-ramp conversion were checked numerically. No new physical display/colorimeter measurements were performed. The 1,000-to-364-nit example describes the computed old transform, not a measured panel output.