[Target] Keep all implied features in canonical representation - #9253
Open
alexreinking wants to merge 2 commits into
Open
[Target] Keep all implied features in canonical representation#9253alexreinking wants to merge 2 commits into
alexreinking wants to merge 2 commits into
Conversation
alexreinking
force-pushed
the
alexreinking/algebraic-targets
branch
from
July 28, 2026 21:10
b3a83a9 to
f77cff8
Compare
alexreinking
force-pushed
the
alexreinking/algebraic-targets
branch
2 times, most recently
from
July 28, 2026 23:26
4f95024 to
ff18cb1
Compare
Merged
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alexreinking/target-tables #9253 +/- ##
==============================================================
- Coverage 70.17% 70.11% -0.07%
==============================================================
Files 255 255
Lines 79035 78973 -62
Branches 18911 18875 -36
==============================================================
- Hits 55464 55372 -92
- Misses 17896 17915 +19
- Partials 5675 5686 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
added a commit
to halide/build_bot
that referenced
this pull request
Jul 29, 2026
…open PRs (#361) Previously the scheduler only built PRs whose base branch was literally "main", so a PR whose base is another PR's branch (a stacked PR, e.g. halide/Halide#9253 based on #9251) was silently never scheduled. Move the gating into SafeGitHubEventHandler.handle_pull_request, where the full PR payload is available: - base == "main": build, as before. - base is a release/N.x branch: skip, as before. - PR is part of a recognized GitHub Stack (the `stack` payload field): build. refs/pull/<N>/merge for a stacked PR is chained through every lower PR's own merge ref, so building it already transitively tests against stack.base.ref (main) -- confirmed by inspecting the actual merge commit parents on halide/Halide#9249-#9253. - base is otherwise the head of another open PR in the same repo (an informal/pre-Stacks-feature chain): build. - anything else (an untracked, possibly short-lived branch): skip, to avoid wasting CI on builds that can be invalidated without warning. Fixes #148 Co-authored-by: Claude Sonnet 5 <[email protected]>
alexreinking
marked this pull request as ready for review
July 29, 2026 13:58
alexreinking
requested review from
halidebuildbots
and removed request for
halidebuildbots
July 29, 2026 15:22
- de-duplicated orphaned features handling - fixed a bug with trace-feature simplification - added enum-ends to os/processor
alexreinking
force-pushed
the
alexreinking/algebraic-targets
branch
from
July 29, 2026 18:12
ff18cb1 to
6f40c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on my comment in #9241.
This adjusts Target to always have a single, stable, representation by filling in implied target features.
This leans into the mathematical lattice structure targets have.
Breaking changes
The
target.to_string()function now shows a minimal target; clients wanting to see everything should use.to_complete_target().Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬