Repository navigation
refactor(permission): parse sourced config entries once - #796
Merged
Merged
Conversation
hakula139
force-pushed
the
refactor/permission-config-parse
branch
from
October 30, 2026 14:12
7a85a48 to
0b1d71a
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hakula139
force-pushed
the
refactor/permission-config-parse
branch
from
October 30, 2026 14:55
0b1d71a to
3e706c2
Compare
hakula139
force-pushed
the
refactor/permission-shell-modules
branch
from
November 1, 2026 09:20
7c02e89 to
651e8eb
Compare
hakula139
force-pushed
the
refactor/permission-config-parse
branch
from
November 1, 2026 09:41
3e706c2 to
85febb2
Compare
hakula139
force-pushed
the
refactor/permission-config-parse
branch
from
November 1, 2026 10:13
2559e7a to
8c4361a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Permission configuration was parsed during per-file validation and again while constructing policy. This PR compiles sourced rules and validates extra roots once after the layers merge, retaining each entry's original file context and rejecting invalid lower-layer values.
Test plan
2559e7a39passed: formatting, build, both Clippy runs, rustdoc, coverage, pnpm format/lint/spellcheck, and hooks. 3,497 tests passed with five existing paid-live tests ignored. Line coverage is 99.24%.8c4361a10, including Rust on Linux, macOS and Windows, MSRV, lint, both Nix builds, CI Result and Codecov.Source::File; permission-list entries come from file layers, so other sources cannot reach this path.