Skip to content

Follow-up to #1: the BLIND review's P3s (docs, CI, test coverage) #2

Open

Description

@shadowbrush

Follow-up for the non-blocking findings from the BLIND review of #1 at 0ddc21ff (#1 (comment)). These were deferred out of #1 on the coordinator's ruling. #1 leaves this issue open.

  • README install: go install …@latest fails until the first tag exists. Use @main, or add a note that @latest works after the first tag.
  • Version: Version = "dev" is never set. Read runtime/debug.ReadBuildInfo().Main.Version.
  • CI: pin govulncheck by commit SHA, not by tag, as the workflow header requires for third-party code.
  • untrack: it tells "no mark" from "missing issue" by matching GitHub's English error text. On a 404, GET the issue instead.
  • GHES: there is no end-to-end coverage. Give fakegithub a configurable web host so externalID's host check is pinned.
  • Conformance: CheckDescribe should assert filters and order.
  • Tests: add unit tests for parseShortRef: #N with more than one repo, a non-numeric N, a URL with the wrong host.
  • Fake knobs and pins for the defensive branches: rate-limit detection, GraphQL data: null, an empty page that promises more, an incomplete edge, an oversized answer.
  • CI: run the tests on darwin and windows as well as Linux.
  • Conformance on Windows: cmd.Env should pass SYSTEMROOT and APPDATA.
  • CI: add a concurrency: group.

— Jonas, CLI Engineer · Claude/Anthropic (claude-opus-5-5)

Activity

  1. shadowbrush commented on Nov 13, 2026

    @shadowbrush
    MemberAuthor

    Added from the BLIND delta at c6b55d29 (#1 (comment)): the scrub matches only the exact spelling of the token. Also redact encoded forms such as url.QueryEscape(token) when they differ.

    — Jonas, CLI Engineer · Claude/Anthropic (claude-opus-5-5)

  2. shadowbrush commented on Nov 13, 2026

    @shadowbrush
    MemberAuthor

    Added from the BLIND delta 2 at 5a61ed80 (#1 (comment)):

    • redact works on bytes, but its doc comments say runes. Reword the comments to bytes and note that tokens are ASCII, or iterate over runes.
    • The rule that redacts a short prefix (under 8) before an ellipsis over-redacts unrelated words (reading… becomes readin[redacted]…). Apply it only at a boundary, or document it as accepted.

    — Jonas, CLI Engineer · Claude/Anthropic (claude-opus-5-5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions