Repository navigation
team events/alarm: render both cadence alarm strings (lead-cadence + legacy coordinator-cadence) - #2638
Open
shadowbrush wants to merge 3 commits into
Open
team events/alarm: render both cadence alarm strings (lead-cadence + legacy coordinator-cadence)#2638shadowbrush wants to merge 3 commits into
shadowbrush wants to merge 3 commits into
Conversation
…red on main) Worker: Jessie (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:jessie> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…adence, say the old string is on pre-rename events (Refs #2555, hadron-server#4375) Worker: Jessie (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:jessie> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2555. Companion to hadron-server#4375 (rename of the cadence alarm's emitted type to
alarm.lead-cadence; the server emits the new string and reads both).SEQUENCING: this must merge before or with the server #4375 PR (per the re-FIT and the gate). Dispatch was open; only the merge is sequenced. State this in the ready call.
What changes
internal/cmd/team/events.go, every site the gate lists (premises re-verified on current main, nolead-cadenceanywhere before this):tasklessAlarmCell:case "alarm.lead-cadence", "alarm.coordinator-cadence"(TASK cellcoordinator <name>, unchanged text, no payload text).team alarm ack(the second exact compare the gate added): both strings, so the receipt still sayson coordinator <name>.team events,team alarm(Short and Long),team alarm ack,team alarms(alarms.go), and the agentic usage paragraph: one wording for both strings, plus one line thatalarm.coordinator-cadenceappears on events raised before the rename.docs/help-inventory.md: five rows (team,team alarm,team alarm ack,team alarms,team events) regenerated, now unread for the next evaluator pass.The cell keeps the word "coordinator" (the existing output and its pins); only the type string it matches grows.
Pins
TestCadenceAlarmBothTypesRender2555: list and ack for both strings (red on main foralarm.lead-cadencein the first commit; the legacy arm is pinned too).TestCadenceAlarmHelpNamesBothStrings2555: the three help pages name both strings and the "before the rename" line.go test ./...,make lint,make help-inventory-checkpass locally. Out of scope: everything else in server#4375, cor:agt:110:05 step 3, alarm subscription.— Jessie, CLI Engineer · Claude Sonnet 5.5
🤖 Generated with Claude Code