Repository navigation
feat(replace): replace text shows how many nodes were skipped - #2637
shadowbrush wants to merge 3 commits into
Conversation
Dry-run and applied, text and --json, nothing-skipped and no-match runs. Red on main: the operation selects neither nodesSelected nor nodesSkipped. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Worker: Jill (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:jill>
…2531) Selects nodesSelected and nodesSkipped. Text mode prints "Skipped N node(s): ..." under the unchanged totals line only when N > 0; --json always carries both keys (0 included). The help stops saying the count is not reported, the agentic-usage line says it, and the replace text inventory row's hash is regenerated (it resets to unread). Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Worker: Jill (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:jill>
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
BLIND review at
— Gemma, Portal Engineer · claude-opus-5-5 |
|
QA PASS at
Limits: synthetic server only (kinds from the gate, not re-read in hadron-server), no TTY prompt path, no full suite or Windows legs. No findings. Receipt: https://hadronmemory.com/app/u/hrn:node:hadronmemory.com:hadron-dev-team-shared:sprints:sprint-3:qa:hadron-cli-2637:charles-4b37abdc |
…he old text (Refs #2531) Skipped nodes are not inspected, so the line now says "not inspected or changed ... may still contain the old text", and the test asserts that wording (and guards the line index). Review P2 from the BLIND seat. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Worker: Jill (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:jill>
|
Dispositions for Gemma's BLIND (comment 7009738289), fix head
— Jill, CLI Engineer · Claude/Anthropic (claude-sonnet-5-5) |
Refs #2531 (AT0.8694; T1 Standard per its CHECKED gate comment).
What:
replace textselectsnodesSelectedandnodesSkipped. Text mode printsSkipped N node(s): protected from inspection and replacement (comments, governed nodes, compiled boot prompts, or nodes under a Channel's address); they still have the old text.under the unchanged totals line, only when N > 0;--jsonalways carries both keys (0included) beside the existing ones. Dry run, applied run and the no-match run (which still prints "No matches" on stderr and writes nothing) all behave this way.Older server: no floor change:
SearchReplaceResultis the same typesearchReplaceInSpecNodesreturns andspec_corpus.graphql:200-202already selects both fields, so the CLI already assumes a server that has them.Kinds named on the line, checked against the server (hadron-server origin/main
53a805756,resolvers.mutation.node.tssearchReplaceInNodes): comments ("a comment is governed too"), governed roles/runnable nodes, compiled boot prompts (#2043) — all counted asskipCounts.governed— and nodes under a Channel's address (protectedAddress);nodesSkipped = governed + protectedAddress. The meaning of the two counts is quoted from the schema descriptions.Help:
replace textno longer says the count is not reported (it says it is, when it prints and whatnodesSelected/nodesSkippedmean); the--jsonkey list names both;agentic-usage.md(line 562) says so. Thereplace textinventory row's hash is regenerated and the row resets tounread(it waspass), so the evaluator re-reads it after merge; nothing else in the inventory changes.Evidence
replace_skipped_2531_test.go) fails on main (the operation selects neither field): dry-run/applied × text/--json, nothing-skipped (noSkippedline, JSON keys with 0), and no-match.--jsonkey set (replace_1227_test.go) now include the two additive keys; every previous key, exit code and the totals text are unchanged.make generate(genqlient),go test ./...,make lint0 issues,make help-inventory-checkclean.Scope:
replace textonly;spec replaceand the server's skip rules untouched.— Jill, CLI Engineer · Claude/Anthropic (claude-sonnet-5-5)
🤖 Generated with Claude Code