Repository navigation
task finish --worked-from: record the role tasks followed (#2514) - #2633
Open
shadowbrush wants to merge 8 commits into
Open
shadowbrush wants to merge 8 commits into
shadowbrush wants to merge 8 commits into
Conversation
…FromRoleTaskRefs) (#2514) Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…TaskFields fragment (#2514) Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…h the help inventory (#2514) Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Worker: Joran (cli-engineer) <hrn:worker:hadronmemory.com:hadron-dev-team:joran> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hadron team task finish --worked-from REF(repeatable, at most 10) records the role tasks the assignee followed, and the stored{nodeId, urn, revision}refs show in the finish receipt,task getand--json(result.workedFromRoleTaskRefs). Companion C1 of #4360, over hadron-server#4414.Closes #2514. Refs #4360 (the project) and hadron-memory/hadron-server#4414; both stay open, as the issue says.
What changed
--worked-from, aStringArray. An eleventh ref or a blank one exits 2 before any request. Everything else (unreadable, missing, not runnable, repeated) is the server's call. Combines with--findings-file(the findings finish document carries the same variable).null, when the flag is absent (omitemptyonAgentTaskResultInput.workedFromRoleTaskRefsand on the findings document's$workedFrom), so the no-flag request is byte-identical to today.worked from:lines (URN and revision) in the receipt andtask get;result.workedFromRoleTaskRefsin--json, omitted when none, so a task finished without refs renders exactly as before.TASK_ROLE_TASK_REFS_INVALIDprints a fixed message that names no reference, exit 2 (codeForExtensionand theTestMapErrortable).Long,Example, flag usage) andagentic-usage.md.Schema snapshot
Refreshed at hadron-server 46865d36a (merge of #4449, the first revision with the field), in a detached worktree under my scratchpad:
make schema HADRON_SERVER_DIR=… SDL_EXPORT=…printedschema: … @ 46865d36a, andmake schema-checkandmake tools-manifest-checkpass against it. The refresh also carries the other server changes merged by then. The only one that needed CLI action is the App-secret read-client surface (issueSecretReadClient,revealSecret,mySecretReadClients, from hadron-server#3998 S3): the coverage matrix lists them asgap #2631(filed here, no behaviour change).Disclosures for the seats
AgentTaskFieldsfragment, as the gate's plan says, so an older server rejects each task query as a schema-skew refusal (exit 2). The repo already accepts that for handles;agentic-usage.mdnow says so. Deploy order: server first.ClaimUntrackedTaskItems*documents embed that fragment, so their byte-for-byte hashes infind_untracked_no_team_1622_test.goare re-pinned (same precedent as cli#2206); the list document hash did not move.docs/help-inventory.md: theteam task finishrow resets tounreadbecause its help changed.Tests (red first)
internal/cmd/team_task_worked_from_2514_test.go, committed red on main before the implementation: refs sent in order; receipt and--jsonshow both with revision; eleven refs and a blank ref refuse with no request; ten are sent; no flag omits the field and leaves text and--jsonunchanged; the refusal echoes no ref (the fake server's message contains one) and exits 2; the findings path carries the refs and omits them when absent;task getwith and without refs. Mutants: cap removed (fails), fixed message removed (fails),omitemptyremoved in the generated input (fails).Local:
make test,make lint,make schema-check,make help-inventory-check,make coverage-matrix-check,make tools-manifest-checkall pass at this head after merging main (the only overlapping file wasdocs/help-inventory.md).— Joran, cli-engineer · claude-sonnet-5-5
Worker: Joran (cli-engineer) https://hadronmemory.com/app/u/hrn:worker:hadronmemory.com:hadron-dev-team:joran
🤖 Generated with Claude Code