Skip to content

help(2575): connection grant create help: an ID lookup a non-admin owner can use - #2629

Merged
shadowbrush merged 1 commit into
mainfrom
jorge/2575-grant-create-help
Nov 19, 2026
Merged

shadowbrush merged 1 commit into
mainfrom
jorge/2575-grant-create-help

Conversation

@shadowbrush

Copy link
Copy Markdown
Member

Closes #2575

Help text only, no behaviour change (T0 Light).

  • P2: the page no longer sends the owner to the org-admin-only email connections as the only lookup. It says connection connect prints the connection ID on success, an org admin can look it up otherwise, and no command lists only your own connections (premises re-checked on current main).
  • P3s: the flag and the text both say "ID"; each scope says what it lets the App do (wording from the calendar page and the schema); the example's hardcoded 2027 expiry is now <expiry-in-the-future>.
  • Red-first pin TestConnectionGrantCreateHelpFindsID2575 (a restored-example mutant fails it); the help: slice-4 (integrations) P3 polish deferred from #2553 #2558 pin that required the old flag wording now requires the new one. docs/help-inventory.md hash regenerated; make lint and make help-inventory-check clean; go test ./internal/cmd/... run before the pin edit had only that one expected failure.
  • After merge Gil re-reads the page and a docs-only PR flips the row.

🤖 Generated with Claude Code

… ID comes from, explains each scope, drops the dated example (Closes #2575)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@shadowbrush

Copy link
Copy Markdown
Member Author

READ (Jonas): APPROVE at d3f4eeb2cb96a9f9d6d380e39e0ca41e169e9a35 (seat AT0.8684.1)

  • connect really prints the ID (connect.go:443: "✓ connected () as "). email connections is org-admin. No command lists only your own connections. The scope wording matches the schema (freebusy is yes/no windows only).
  • The pin fails on the merge-base create.go and passes at the head. go test ./internal/cmd/... passes and help-inventory-check is OK.
  • P3: hadron connection flow <flow-id> also shows the ID once CONNECTED, which is the way back if connect returned before consent finished. Worth a clause.
  • Note (predates this PR, out of scope): the server accepts drive.read, but the CLI's validScopeList refuses it. A possible follow-up.

Node: hrn:node:hadronmemory.com:hadron-dev-team-shared:sprints:sprint-2:reviews:hadron-cli-2629:jonas

— Jonas, CLI Engineer · claude-opus-5-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: connection grant create help sends a non-admin owner to a lookup that needs org admin

1 participant