Repository navigation
XS✔ ◾ fix: require extractKey when the ExternalSecret is enabled - #11
Merged
Merged
Conversation
An empty secrets.externalSecret.extractKey rendered key: null, which the ExternalSecret CRD rejects because extract.key is a required string. Fail at render time with a clear message instead, and quote the key.
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
Dimitris-Mil
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
secrets.externalSecret.enabled: trueand noextractKey, the chart renderedkey: nullunderspec.dataFrom[0].extract. Theexternal-secrets.io/v1ExternalSecret schema requiresextract.keyas a string, so the API server rejects the resource and the release fails at apply time with a schema error.The template now uses
required, so the same mistake fails at render time withsecrets.externalSecret.extractKey is required when secrets.externalSecret.enabled is true. The key is also quoted.No working config changes: a release that deploys today already sets
extractKey. The kubernetes-deploy base sets${env_name}/services/typesense.Ported from the same fix in hackthebox/helm-charts#453, made there before the chart moved to this repo.
Tests: added a case for the empty key.
mise run test(94/94) andmise run lintpass. No version bump, which is left to the release commit.