Repository navigation
Conversation
govulncheck reported 10 reachable vulnerabilities in the Go 1.26.8 standard library (net/http, crypto/tls, crypto/x509, mime/multipart; fixed in 1.26.9 and 1.26.10). Five of them also affect golang.org/x/net v0.57.0 (fixed in v0.60.0). The go directive, mise.toml and the Dockerfile builder stage move together to 1.26.10. CI and the release build resolve Go from the go directive, so this is what puts the fixed stdlib into the released binaries and the ECR image. x/net v0.60.0 pulls x/sys v0.48.0, x/term v0.46.0 and x/text v0.42.0.
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were identified, and all approval-readiness assessments support approval.
No open issues 🎉
What changed in this PR
Updates the Go toolchain and networking dependencies to versions containing security fixes, while keeping local development, module metadata, and the production Docker build aligned.
Changes:
- Upgrades Go from 1.26.8 to 1.26.10 in
go.mod,mise.toml, and the Docker builder image. - Upgrades
golang.org/x/netto v0.60.0 and refreshes relatedx/sys,x/term, andx/textdependencies. - Refreshes
go.sumchecksums for the updated modules.
| File | Description |
|---|---|
mise.toml |
Pins local development to Go 1.26.10. |
go.sum |
Records checksums for the updated modules. |
go.mod |
Updates the Go directive and dependency versions. |
Dockerfile |
Uses the Go 1.26.10 Alpine builder image. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-version-file: go.mod, so the go directive is what puts the fixed stdlib into the released binaries.Checks run locally with Go 1.26.10:
go build ./...: exit 0go vet ./...: exit 0go test ./...: exit 0golangci-lint run ./...(v2.12.2, the CI pin): exit 1 with the same 4 revive findings as master (unusedtparams in tests). CI runs it withonly-new-issues.govulncheck ./...: exit 0, no vulnerabilities found.Not verified: Docker image build, goreleaser build, e2e bats suite.