Repository navigation
Resolve active season id from the season list - #206
Open
ToxicBiohazard wants to merge 2 commits into
Open
ToxicBiohazard wants to merge 2 commits into
ToxicBiohazard wants to merge 2 commits into
Conversation
Stop relying on SEASON_ID and use the active entry from /v4/season/list for season rank lookups. Co-authored-by: Cursor <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 68.17% 68.39% +0.21%
==========================================
Files 78 78
Lines 3702 3749 +47
==========================================
+ Hits 2524 2564 +40
- Misses 1178 1185 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Keep the season list result in memory only until the active season's end_date, then fetch the list again. Co-authored-by: Cursor <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
get_season_rankno longer readsSEASON_ID/CURRENT_SEASON_IDfrom the environment. It loads the season id from/api/v4/season/listand uses the entry withactive: true(currently Season 12, id21).That id is then passed to
/v4/user/achievement/season/{userId}/{modelId}. If the list call fails or no season is active, the rank lookup is skipped.SEASON_IDis removed from settings and.test.env. Leftover env values are ignored.Checklist
Put an
xin the boxes that apply.doc.
Additional context
The season list is ordered oldest to newest. The active season is selected by
active: true, not by taking the last item.Made with Cursor