[dimoschi]

Types of changes

• Bugfix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality not to work as expected).
• Documentation Update (if none of the other choices applies).

Proposed changes

Warnings no longer log a traceback. A warning is a handled condition, so a traceback only buries real errors. Errors keep their traceback, because it makes issues easier to resolve.

This started from the bot's startup log. On every start, the scheduled tasks re-schedule unbans and unmutes for users who left the guild. Each one logged Could not find guild member at WARNING with a full NotFound 10007 Unknown Member traceback, roughly 80 per start.

• Every logger.warning call in src/ that passed exc_info drops it: 7 in src/bot.py, 6 in src/helpers/ban.py, 1 in src/services/role_manager.py. Levels and messages are unchanged. except ... as exc bindings that are now unused are removed.
• The dynamic role reload warning in role_manager.py had only the traceback to say what failed, so its message now ends with the exception text.
• tests/src/test_logging_rules.py parses src/ and fails if any logger.warning call passes exc_info or stack_info, so the rule holds for new code.
• Small fixes pre-commit flagged in the touched files: two f-strings without placeholders, and import order.

Checklist

• I have read and followed the CONTRIBUTING.md
  doc.
• Lint and unit tests pass locally with my changes.
• I have added the necessary documentation (if appropriate).

Additional context

New tests:

• tests/src/test_bot.py: get_member_or_user, each branch's return value, level, message, and whether a traceback is attached (WARNING never, ERROR always).
• tests/src/services/test_role_manager.py: a failed reload keeps the cache and logs the cause without a traceback.
• tests/src/test_logging_rules.py: the rule above. It failed with 14 call sites before the change.

Full suite: 328 passed.

[codecov]

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.64%. Comparing base (99fe0e8) to head (7e72604).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/bot.py	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   67.20%   66.64%   -0.56%     
==========================================
  Files          74       76       +2     
  Lines        3436     3586     +150     
==========================================
+ Hits         2309     2390      +81     
- Misses       1127     1196      +69     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ToxicBiohazard]

Thanks for this. The ~80 NotFound tracebacks on every startup are real noise, and "no traceback for warnings, keep it for errors" makes sense to me. The AST test is a nice way to keep it that way, and good catch on the alembic fileConfig disabling the loggers.

Two things I'd like changed before merging:

1. The HTTPException warnings in ban.py now don't tell us what actually went wrong. Those aren't routine like a member leaving, so we still need the cause in the log.
2. The message renames in get_member_or_user were only done in one of the two fallback branches.

The rest are small nits.

[ToxicBiohazard]

Same problem as the ban HTTPException at line 361. If the DM fails, we don't know which Discord error it was. Can we add : {exc} here too (with except HTTPException as exc:)?

Also this says "unban" but it's the DM sent before a ban. Not from this PR, but could you fix it while you're on this line?

[dimoschi]

Done in 7e72604. Added the cause and fixed the wording: HTTPException when trying to DM user with ID {id} about their ban: {exc}.

[ToxicBiohazard]

Looks good, thanks!