Keep ReviewHog pending while status says reviewing - #205
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The logic change is narrowly scoped, covered by a targeted regression test, and doesn’t introduce correctness or safety issues beyond minor documentation nits noted in review comments.
Pull request overview
This PR adjusts the “pending reviews” detection logic for ReviewHog so a status comment remains treated as in-progress when it still contains the "is reviewing" phrase, even if GitHub updates the comment timestamp. It also updates documentation and adds a regression test covering the step-progress status update case.
Changes:
- Treat ReviewHog status comments as not completing a round when the comment body still contains
"is reviewing", even ifupdated_atadvances. - Preserve the existing completion signals for marked reviews and for marked status comments that no longer indicate active reviewing.
- Add a regression test for a “step 3 of 6” status update and document the new status-phrase check.
File summaries
| File | Description |
|---|---|
| ai/skills/wait-for-pr-reviews/SKILL.md | Updates the security note to reflect that the tooling reads the "is reviewing" status phrase in addition to markers/timestamps. |
| ai/skills/wait-for-pr-reviews/scripts/tests/test-pending-reviews.sh | Adds a regression test ensuring an updated status comment that still says "is reviewing" remains pending; updates header commentary. |
| ai/skills/wait-for-pr-reviews/scripts/helpers/pending-reviews.jq | Implements the new “in progress if body contains is reviewing” check for status-comment completion detection. |
| ai/skills/wait-for-pr-reviews/scripts/check-pending-reviews.sh | Documents the updated completion semantics for ReviewHog status comments in the wrapper’s header comment. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
+22
| # edited in place as the round progresses and when it finishes). A marked review | ||
| # submitted after the label completes the round. A marked status comment also | ||
| # completes the round when updated after the label and its own creation, unless it | ||
| # still says "is reviewing". A comment whose updated_at equals its created_at is | ||
| # the fresh placeholder, i.e. the round just started. |
Comment on lines
+4
to
+7
| # The verdict decides which PR reviewers are still mid-review: the ReviewHog | ||
| # label versus requested bot reviewers. Completion is read from machine | ||
| # markers and timestamps - a marker in a review/comment body plus an ordering | ||
| # against the label event - never from the bot's prose. | ||
| # markers and timestamps. An updated status comment remains pending while it | ||
| # still says "is reviewing". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is reviewing, even after GitHub updates the comment timestamp.is reviewing.Test plan
git diff --check.