Repository navigation
fix(code-graph): readable boundary of a --link graph - #140
Merged
Merged
Conversation
An external node is labelled by the PATH it was found by (`picasso: labs/ptbr-pdf`; the first PATH in sorted order if several resolve to one node) and keeps its own label as `linked_label`, shown in the side panel. The Relations legend lists only the relations the graph has and now has depends_on, with its own colour. External nodes and the files that point at them are always labelled. The README Size table has the new binary sizes. Tested: nix flake check --no-update-lock-file in labs/code-graph (build+cargo test, clippy -D warnings, fmt, size, smoke); real case ptbr-writer + forks/picasso, headless Chrome screenshot; nix build, nix build .#static, stat, xz -9e for the sizes Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #139 (merged without these fixes): external nodes are labelled by the PATH they were found by (original label kept as
linked_labeland in the side panel); the Relations legend lists only present relations and has depends_on with its own colour; external nodes and the files that link to them are always labelled; README Size table updated (15.9 MiB glibc 16,636,064 bytes; static 16,734,160 bytes; xz -9e 1,192,652 bytes). Not run: aarch64 checks.