Repository navigation
Release 0.12.0 - #595
Merged
Merged
Release 0.12.0#595
Conversation
* fix error * remove double test * fix f string * disable test for debugging purposes * add function to get zcellcenters * use get_zcellcenters instead of flopy function
Remove ecmwflibs from dependencies
* fix #549 - find first cross method to guarantee finding the first point value is reached. - add right/left kwargs to allow setting values for values above/below interpolation array * improve performance get_isosurface - add optimized numpy method - add numba implementation - support for dask arrays and parallel - add numba as dependency - add tests for all 1d methods * make numba optional
add hatch_layers function to cross sections
* Run model in directory with same name as notebook, add this to gitignore * Imporve tests make sure tests in test_003mfpackages.py are not ignored Run tests in a model directory set by a fixture * forgot to commit util.py and some other updates * Remove tests from test_001_model.py, and some other changes Replace tmpdir by the newer tmp_path * Fix hanging of tests, where dataset is loaded twice * Fix warnings in tests * Make sure all file-handles are closed in tests * Add extra tests * Remove tight layout, and make sure test can be ran outside pytest * some minor changes * Some minor formatting issues * Remove remaining direct use of tempfile in tests keep use of tempfile in caching and encoding * Update github actions
* add new methods for geulen * ruff * codacy * minor changes * add warning * Update nlmod/plot/plot.py Co-authored-by: Copilot <[email protected]> * Update method * remove output nb * codacy * tiny fix * textual * better debug message * Update nlmod/read/geotop.py * add tests and fix edge cases * ValueError instead of assert * fix split layer order --------- Co-authored-by: Copilot <[email protected]>
Improve checking of ds type (structured or vertex)
added 'na_filter=False' to read_csv in read_gleg in nlmod.read.regis.py
* Add HFB package builder from dataframes * Address HFB static analysis findings * Replace HFB asserts with explicit errors * Use FloPy HFB line routing * Pin FloPy to HFB utility commit * Use FloPy develop for HFB utility * Deprecate legacy HFB routing helpers
…tom variable names
… `pname="MY_RIV" ` + some other minor improvements
+ expose layer label position in DatasetCrossSection
- ensure season timeseries is defined for last season in model - add small eps to rbot to avoid floating point issues with mf6
…a aggregation (#582) * Aggregate lake pieces per cell in lake_from_gdf; tolerate float-noise strt A lake commonly intersects a grid cell in multiple polygon pieces (e.g. straight from nlmod.grid.gdf_to_grid). lake_from_gdf turned each row into its own VERTICAL connection over the full cell area with bedleak = 1/clake, multiply-counting the lake-aquifer exchange. Pieces of one lake within a cell now collapse to a single connection with clake = cell_area / sum(piece_area / clake), the same area-weighted aggregation nlmod.gwf.surface_water.aggregate applies to RIV and DRN celldata. Numeric per-lake settings are now compared with np.allclose(rtol=1e-8) so aggregated inputs carrying float-level noise (e.g. area-weighted stages) are not rejected by the single-value check. Both regression tests fail on unchanged dev: three connections with bedleak 0.1 instead of two with area-weighted bedleak, and an AssertionError on a 1e-12 strt difference. * Apply review suggestions: clearer lake piece wording and error message
Collaborator
|
…me in ds with another name (e.g. precipitation) (#604)
* Allow user to customize output control package kwargs * restore ghb and drn functions to their original behaviour * split lines in function oc to avoid linting error during PR
Improve obs package
add cdist to exchange
Collaborator
Author
|
Only buisdrainage test is failing at the moment. @rubencalje do you want to check that or do we accept and release :)? |
Collaborator
Author
|
We agreed to do one final pass through the docs prior to making the release. And we'd preferably like to include #602 as a fix after @OnnoEbbens has reviewed, and perhaps create a new issue for the extra file that @TomHottentot wanted to add. |
remove geopandas labels from surface water plot
and clear metadata changes?
* fix bofek * Formatting * Update test_005_external_data.py * Update nlmod/read/bofek.py * Update nlmod/read/bofek.py --------- Co-authored-by: Bas des Tombe <[email protected]> Co-authored-by: OnnoEbbens <[email protected]>
And add some ; to reduce output
In documentation
rubencalje
self-requested a review
November 11, 2026 10:15
rubencalje
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we're ready yet, but maybe time to start creating a new release?
Merge before releasing:
Todo: