Skip to content

fix(tests): preserve state-test context in frame variants - #21

Merged
gurukamath merged 2 commits into
gurukamath:eip-8141/frame-tests-from-legacyfrom
spencer-tb:review/pr-3500-fixes
Sep 3, 2026
Merged

gurukamath merged 2 commits into
gurukamath:eip-8141/frame-tests-from-legacyfrom
spencer-tb:review/pr-3500-fixes

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up fixes from reviewing ethereum#3500. They are kept as two separate commits.

  • Preserve StateTest.chain_id when constructing the frame transaction. Otherwise, tests configured with a non-default chain ID produce a transaction with the default chain ID.
  • Preserve the original Environment.gas_limit. GASLIMIT is observable by contracts, so raising a sufficient low limit to the framework default can change test semantics.

Each behavior has a regression test.

@gurukamath
gurukamath merged commit ca11159 into gurukamath:eip-8141/frame-tests-from-legacy Sep 3, 2026
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants