Repository navigation
fix(tests): preserve state-test context in frame variants - #21
Merged
gurukamath merged 2 commits intoSep 3, 2026
Merged
gurukamath merged 2 commits into
gurukamath merged 2 commits into
Conversation
gurukamath
approved these changes
Sep 3, 2026
gurukamath
merged commit Sep 3, 2026
ca11159
into
gurukamath:eip-8141/frame-tests-from-legacy
10 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes from reviewing ethereum#3500. They are kept as two separate commits.
StateTest.chain_idwhen constructing the frame transaction. Otherwise, tests configured with a non-default chain ID produce a transaction with the default chain ID.Environment.gas_limit.GASLIMITis observable by contracts, so raising a sufficient low limit to the framework default can change test semantics.Each behavior has a regression test.