Skip to content

Render puzzles container sponsorship from page data - #17030

Merged
DanielCliftonGuardian merged 2 commits into
mainfrom
render-puzzles-container-spons
Oct 27, 2026
Merged

DanielCliftonGuardian merged 2 commits into
mainfrom
render-puzzles-container-spons

Conversation

@DanielCliftonGuardian

@DanielCliftonGuardian DanielCliftonGuardian commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

Uses each container’s commercial properties to show sponsorship for the reader’s edition, reusing the existing container design. Hub and container sponsorship remain independent.

Adds validation and Playwright coverage for edition targeting, ad-free readers and sponsor click tracking.

Frontend pr

Screenshots

image image

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Oct 26, 2026
@DanielCliftonGuardian DanielCliftonGuardian added run_chromatic Runs chromatic when label is applied feature Departmental tracking: work on a new feature labels Oct 26, 2026
@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:5648ffed369bf24764113581e17bd626da6d3e9f8b81e5d156f08c89cc61bbfc

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:5648ffed369bf24764113581e17bd626da6d3e9f8b81e5d156f08c89cc61bbfc"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-render-puzzles-container-spons"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-33034"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 26, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@gustavo-olmedo gustavo-olmedo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielCliftonGuardian
DanielCliftonGuardian added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 5960029 Oct 27, 2026
42 of 45 checks passed
@DanielCliftonGuardian
DanielCliftonGuardian deleted the render-puzzles-container-spons branch October 27, 2026 12:48
@gu-prout

gu-prout Bot commented Oct 27, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @DanielCliftonGuardian 5 minutes and 44 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants