Skip to content

Disable swipe in interactive grid - #16992

Merged
frederickobrien merged 2 commits into
mainfrom
no-swipe-in-interactve-grid
Oct 22, 2026
Merged

frederickobrien merged 2 commits into
mainfrom
no-swipe-in-interactve-grid

Conversation

@frederickobrien

Copy link
Copy Markdown
Contributor

Restoring a feature that slipped through the net in the recent move to a grid based interactive layout. See #16974 and #14111 for context

@frederickobrien frederickobrien self-assigned this Oct 22, 2026
@frederickobrien frederickobrien added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:e253851bb13f633bdc06f4d08c4db6bea0be8a21353c962202ec3ac86f695af5

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:e253851bb13f633bdc06f4d08c4db6bea0be8a21353c962202ec3ac86f695af5"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-no-swipe-in-interactve-grid"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32752"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@frederickobrien frederickobrien added this to the Interactives milestone Oct 22, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

@joshuaguardian

Copy link
Copy Markdown
Contributor

can any tests/stories be added to cover this change?

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Oct 22, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 22, 2026
@frederickobrien
frederickobrien added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 8c33e4c Oct 22, 2026
30 checks passed
@frederickobrien
frederickobrien deleted the no-swipe-in-interactve-grid branch October 22, 2026 09:14
@frederickobrien

Copy link
Copy Markdown
Contributor Author

can any tests/stories be added to cover this change?

The component returns null so it's a little finicky - I've merged this in the interest of getting a fix live but keen to revisit testing around StandardLayout in the coming weeks

@gu-prout

gu-prout Bot commented Oct 22, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @frederickobrien 6 minutes and 10 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants