Skip to content

Add ec2 vs ecs integration comparison tests - #16975

Draft
aug24 wants to merge 1 commit into
mainfrom
add-ec2-vs-ecs-integration-comparison-tests
Draft

aug24 wants to merge 1 commit into
mainfrom
add-ec2-vs-ecs-integration-comparison-tests

Conversation

@aug24

@aug24 aug24 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

What does this change?

The PR adds some integration tests to facilitate a/b testing between ECS and EC2.

Why?

Before we cut in even 1% of traffic, we would like confidence that the responses are functionally equal. We can then safely go on to consider if they are non-functionally good.

How has this change been tested?

Screenshots

Before After
before after

@aug24
aug24 requested a review from a team as a code owner October 20, 2026 11:55
@aug24
aug24 marked this pull request as draft October 20, 2026 11:56
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:1835de3f16b66d9bb6c6b8ebaf6fd30248c382514a7b7fcab2cd14c5100080b9

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:1835de3f16b66d9bb6c6b8ebaf6fd30248c382514a7b7fcab2cd14c5100080b9"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-add-ec2-vs-ecs-integration-comparison-tests"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32857"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@aug24 aug24 added the feature Departmental tracking: work on a new feature label Oct 20, 2026
@aug24
aug24 force-pushed the add-ec2-vs-ecs-integration-comparison-tests branch from dcbd3da to c9cb992 Compare October 21, 2026 08:51
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

@aug24
aug24 force-pushed the add-ec2-vs-ecs-integration-comparison-tests branch 2 times, most recently from c7a1c70 to aaa8469 Compare October 23, 2026 08:52
@aug24
aug24 force-pushed the add-ec2-vs-ecs-integration-comparison-tests branch from aaa8469 to e83b8c8 Compare October 23, 2026 09:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant