Repository navigation
Conversation
aug24
marked this pull request as draft
October 20, 2026 11:56
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:1835de3f16b66d9bb6c6b8ebaf6fd30248c382514a7b7fcab2cd14c5100080b9"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-add-ec2-vs-ecs-integration-comparison-tests"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32857"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
aug24
force-pushed
the
add-ec2-vs-ecs-integration-comparison-tests
branch
from
October 21, 2026 08:51
dcbd3da to
c9cb992
Compare
aug24
force-pushed
the
add-ec2-vs-ecs-integration-comparison-tests
branch
2 times, most recently
from
October 23, 2026 08:52
c7a1c70 to
aaa8469
Compare
aug24
force-pushed
the
add-ec2-vs-ecs-integration-comparison-tests
branch
from
October 23, 2026 09:10
aaa8469 to
e83b8c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The PR adds some integration tests to facilitate a/b testing between ECS and EC2.
Why?
Before we cut in even 1% of traffic, we would like confidence that the responses are functionally equal. We can then safely go on to consider if they are non-functionally good.
How has this change been tested?
Screenshots