Conversation
|
@martinbonnin as agreed at the GraphQL-over-HTTP working group, I've updated this to lean heavily on the GraphQL spec to define the result shapes, rather than redefining them here. I've also fixed outdated references to terms in the spec that have since been refined - it wasn't just "GraphQL response" that was out of date (as you rightly caught!), but also "field error" has been replaced with "execution error" and the section links were also broken due to capitalization differences. I've moved to linking to the term definitions instead of section headers as I believe these links will be more stable. I've linked to the Sept 2025 main spec release right now, but if we can get a Sept 2026 release ready before this goes out I'll update the reference so they can go out either together or slightly staggered (HTTP following main spec) - that can be done in a follow up to this PR. Please take a look and let me know what you think. |
|
@benjie I can't approve my own PR but LGTM! |
| { | ||
| "biblio": { | ||
| "https://spec.graphql.org/draft/": { | ||
| "https://spec.graphql.org/September2025/": { |
There was a problem hiding this comment.
Was this meant to be commited? Do we have a release already? 👀
There was a problem hiding this comment.
Wrong year, Martin!
I've linked to the Sept 2025 main spec release right now, but if we can get a Sept 2026 release ready before this goes out I'll update the reference so they can go out either together or slightly staggered (HTTP following main spec) - that can be done in a follow up to this PR.
There was a problem hiding this comment.
😂 What a year, huh?
Sounds good 👍 Thanks!
Just like there is
GraphQL-over-HTTP request, this PR introducesGraphQL-over-HTTP response.Using GraphQL response was misleading because the HTTP specification doesn't say anything about response streams and we might end up using a separate media type for this (
application/graphql-responses+jsonl, ...)Instead, this PR introduces a new
GraphQL-over-HTTP responsethat is either an execution result or a request error result, but not a response stream.