Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<ItemGroup Label="Microsoft">
<PackageVersion Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.10" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.10" />
</ItemGroup>

Expand Down
9 changes: 9 additions & 0 deletions src/FillInTheTextBot.Api/DI/InternalServicesRegistration.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using FillInTheTextBot.Services;
using FillInTheTextBot.Services.BackgroundTasks;
using Microsoft.Extensions.DependencyInjection;

namespace FillInTheTextBot.Api.DI
Expand All @@ -9,6 +10,14 @@ internal static void AddInternalServices(this IServiceCollection services)
{
services.AddTransient<IConversationService, ConversationService>();
services.AddScoped<IDialogflowService, DialogflowService>();

// Продюсеры (IBackgroundTaskQueue) и обработчик (IBackgroundTaskReader) должны
// работать с одним и тем же каналом, поэтому оба интерфейса форвардятся на
// единственный экземпляр BackgroundTaskQueue.
services.AddSingleton<BackgroundTaskQueue>();
services.AddSingleton<IBackgroundTaskQueue>(provider => provider.GetRequiredService<BackgroundTaskQueue>());
services.AddSingleton<IBackgroundTaskReader>(provider => provider.GetRequiredService<BackgroundTaskQueue>());
services.AddHostedService<BackgroundTaskProcessor>();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Threading.Tasks;
using AutoFixture;
using FillInTheTextBot.Services;
using FillInTheTextBot.Services.BackgroundTasks;
using GranSteL.Helpers.Redis;
using MailRu.Marusia.Models;
using MailRu.Marusia.Models.Input;
Expand All @@ -22,6 +23,7 @@ public class MarusiaServiceTests
{
private Mock<IConversationService> _conversationService;
private Mock<IRedisCacheService> _cache;
private Mock<IBackgroundTaskQueue> _backgroundTasks;

private MarusiaService _target;

Expand All @@ -33,7 +35,18 @@ public void InitTest()
_conversationService = new Mock<IConversationService>();
_cache = new Mock<IRedisCacheService>();

_target = new MarusiaService(Mock.Of<ILogger<MarusiaService>>(), _conversationService.Object, _cache.Object);
_backgroundTasks = new Mock<IBackgroundTaskQueue>();

// Фоновые работы выполняются сразу, чтобы тест проверял результат, а не гонку
_backgroundTasks
.Setup(q => q.Enqueue(It.IsAny<string>(), It.IsAny<Func<Task>>()))
.Returns((string _, Func<Task> work) =>
{
work().GetAwaiter().GetResult();
return true;
});

_target = new MarusiaService(Mock.Of<ILogger<MarusiaService>>(), _conversationService.Object, _cache.Object, _backgroundTasks.Object);

_fixture = new Fixture { OmitAutoProperties = true };
}
Expand Down
12 changes: 9 additions & 3 deletions src/FillInTheTextBot.Messengers.Marusia/MarusiaService.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using System.Threading.Tasks;
using FillInTheTextBot.Services;
using FillInTheTextBot.Services.Extensions;
using FillInTheTextBot.Services.BackgroundTasks;
using GranSteL.Helpers.Redis;
using MailRu.Marusia.Models;
using MailRu.Marusia.Models.Input;
Expand All @@ -15,13 +15,16 @@ public class MarusiaService : MessengerService<InputModel, OutputModel>, IMarusi
private const string PongResponse = "pong";

private readonly IRedisCacheService _cache;
private readonly IBackgroundTaskQueue _backgroundTasks;

public MarusiaService(
ILogger<MarusiaService> log,
IConversationService conversationService,
IRedisCacheService cache) : base(log, conversationService)
IRedisCacheService cache,
IBackgroundTaskQueue backgroundTasks) : base(log, conversationService)
{
_cache = cache;
_backgroundTasks = backgroundTasks;
}

protected override Models.Request Before(InputModel input)
Expand Down Expand Up @@ -67,7 +70,10 @@ protected override Task<OutputModel> AfterAsync(InputModel input, Models.Respons

output.AddToSessionState(Models.Response.ScopeStorageKey, response.ScopeKey);

_cache.AddAsync($"marusia:{input.Session?.UserId}", string.Empty, TimeSpan.FromDays(14)).Forget();
var cacheKey = $"marusia:{input.Session?.UserId}";

_backgroundTasks.Enqueue("marusia user mark",
() => _cache.AddAsync(cacheKey, string.Empty, TimeSpan.FromDays(14)));

return Task.FromResult(output);
}
Expand Down
15 changes: 14 additions & 1 deletion src/FillInTheTextBot.Messengers.Sber.Tests/SberServiceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Linq;
using System.Threading.Tasks;
using AutoFixture;
using FillInTheTextBot.Services.BackgroundTasks;
using GranSteL.Helpers.Redis;
using Microsoft.Extensions.Logging;
using Moq;
Expand All @@ -20,6 +21,7 @@ public class SberServiceTests
{
private Mock<Services.IConversationService> _conversationService;
private Mock<IRedisCacheService> _cache;
private Mock<IBackgroundTaskQueue> _backgroundTasks;

private SberService _target;

Expand All @@ -31,7 +33,18 @@ public void InitTest()
_conversationService = new Mock<Services.IConversationService>();
_cache = new Mock<IRedisCacheService>();

_target = new SberService(Mock.Of<ILogger<SberService>>(), _conversationService.Object, _cache.Object);
_backgroundTasks = new Mock<IBackgroundTaskQueue>();

// Фоновые работы выполняются сразу, чтобы тест проверял результат, а не гонку
_backgroundTasks
.Setup(q => q.Enqueue(It.IsAny<string>(), It.IsAny<Func<Task>>()))
.Returns((string _, Func<Task> work) =>
{
work().GetAwaiter().GetResult();
return true;
});

_target = new SberService(Mock.Of<ILogger<SberService>>(), _conversationService.Object, _cache.Object, _backgroundTasks.Object);

_fixture = new Fixture { OmitAutoProperties = true };
}
Expand Down
12 changes: 9 additions & 3 deletions src/FillInTheTextBot.Messengers.Sber/SberService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using System.Collections.Generic;
using System.Threading.Tasks;
using FillInTheTextBot.Services;
using FillInTheTextBot.Services.Extensions;
using FillInTheTextBot.Services.BackgroundTasks;
using GranSteL.Helpers.Redis;
using Microsoft.Extensions.Logging;
using Sber.SmartApp.Models;
Expand All @@ -12,13 +12,16 @@ namespace FillInTheTextBot.Messengers.Sber
public class SberService : MessengerService<Request, Response>, ISberService
{
private readonly IRedisCacheService _cache;
private readonly IBackgroundTaskQueue _backgroundTasks;

public SberService(
ILogger<SberService> log,
IConversationService conversationService,
IRedisCacheService cache) : base(log, conversationService)
IRedisCacheService cache,
IBackgroundTaskQueue backgroundTasks) : base(log, conversationService)
{
_cache = cache;
_backgroundTasks = backgroundTasks;
}

protected override Models.Request Before(Request input)
Expand Down Expand Up @@ -76,7 +79,10 @@ private string TryGetSessionIdAsync(bool? newSession, string userHash)
{
sessionId = Guid.NewGuid().ToString("N");

_cache.AddAsync(cacheKey, sessionId, TimeSpan.FromMinutes(5)).Forget();
var newSessionId = sessionId;

_backgroundTasks.Enqueue("sber session",
() => _cache.AddAsync(cacheKey, newSessionId, TimeSpan.FromMinutes(5)));
}

return sessionId;
Expand Down
Loading
Loading