Repository navigation
Add box patch test appending into a box without children - #80
Merged
Merged
Conversation
New mp4box-patch_box subtest "add-box-empty-container": appends a 'name' box into the tmcd sample entry created by -add self:tc, which has no child box. Fails on gpac master (patch silently dropped), passes with the fix for gpac/gpac#3970.
Contributor
Author
|
Friendly reminder @jeanlf I have a matching test fix here as well for the gpac/gpac#3971 PR you merged. Appreciate you! |
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
mp4box-patch_boxsubtest,add-box-empty-container, for gpac/gpac#3970. It appends anamebox (payloadMYTAPE01) into thetmcdsample entry created by-add self:tc=25,0,0,0,0:fps=25. That sample entry has no child box, and none of the existing box-patch subtests appends into an empty box.On gpac master
7d451dbd0the patch is silently dropped: the tmcd entry stays at Size=34 with no child, and the subtest fails its hash check. With the one-line fix in gpac/gpac#3971 (for gpac/gpac#3970), the entry gets thenamechild and the subtest passes. The reference hash was generated with the fixed build (./make_tests.sh -hash scripts/mp4box-boxpatch.sh). The branch name matches the gpac fix branch,boxpatch-empty-container.Tested on Ubuntu 24.04 aarch64, gcc 13.3.0, with
./make_tests.sh scripts/mp4box-boxpatch.sh scripts/boxpatch.sh:7d451dbd0:mp4box-patch_box: add-box-empty-container:HashFail,gpac-patch_box: OK. 1/2 tests passed (16 subtests, 1 of 17 hash checks failed).mp4box-patch_box: OK,gpac-patch_box: OK. 2/2 tests passed (16 subtests).Files:
scripts/mp4box-boxpatch.sh,media/boxpatch/box_add_empty_container.xml,hash_refs/mp4box-patch_box-add-box-empty-container.hash.Disclosure: this test was prepared with AI assistance (Claude). I reviewed it, and the commands and results above were run on the stated builds.