Repository navigation
Conversation
Signed-off-by: AC <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
An empty JSON feed currently omits
items, whether generated byFeed.ToJSON,Feed.WriteJSON, or marshalingJSONFeeddirectly. The JSON Feed specification requires an array even when there are no entries.Keep
itemsin the encoded object and normalize a nil slice to an empty array in a value-receiver marshaler. Serialization works for values and pointers without modifying the source feed. The existing hub-only output fixture is updated to include the required array.Related Tickets & Documents
No matching issue/PR found in all-state searches for empty feeds, items and JSON. #120 fixes field names and #121 fixes attachment marshaling; neither handles the top-level required array. This branch starts independently from current main.
Added/updated tests?
Run verifications and test
make verifypasses (golangci-lint, gosec, govulncheck).make testpasses with the race detector, 83.2% statement coverage.Tests/security checks used Go 1.27.1 on Linux arm64. Lint used golangci-lint v1.64.8 under Go 1.24.13 with CGO disabled to avoid the v1 linter's incompatibility with Go 1.27 export data and this machine's missing ld.gold. The upstream Go 1.20/1.21, macOS and Windows matrix was not run locally. govulncheck reports no reachable vulnerabilities, while noting advisories outside detected call paths.
AI assistance: prepared and tested with Codex.