fix: onboard google-cloud-asset-v1 to Librarian - #35014
Conversation
aef5135 to
032bb83
Compare
032bb83 to
ce14b85
Compare
ce14b85 to
377e6f4
Compare
c29d4fc to
c96d15a
Compare
1dfb446 to
a2e4c47
Compare
a2e4c47 to
12f6e66
Compare
2d1f8dd to
9327c92
Compare
9327c92 to
23af5f5
Compare
|
@aandreassa This pull request and #35034 are ready for your review and being merged. After |
|
@suztomo @JoeWang1127 please wait on #35037 and #35038 in order to minimize the diffs. I already started working on it googleapis/ruby-common-tools#439 |
|
For this particular pull request of one API, I don't think you have to wait for the work to minimize the diff. The review size is manageable by a human. Having at least one library in |
|
@suztomo please feel free to merge it |
Demonstration PR for
librarian generate google-cloud-asset-v1.Note: The
fix:prefix in the title (fix: onboard google-cloud-asset-v1 to Librarian) is used to add this library to the next Release Please pull request.Commits:
chore: add google-cloud-asset-v1 to librarian.yamlgoogle-cloud-asset-v1inlibrarian.yaml.additional_protos: [google/cloud/orgpolicy/v1/orgpolicy.proto]andruby_cloud_opts.chore: removing OwlBot-related files.OwlBot.yamland.owlbot-manifest.json.chore: regenerate the onboarded library using librarianlibrarian generate google-cloud-asset-v1(built from latestupstream/mainof Librarian &upstream/mainof google-cloud-ruby).Findings & Summary of Code Diff from
upstream/main:Removal of OwlBot-related files:
.OwlBot.yamland.owlbot-manifest.jsondeleted as OwlBot postprocessor is superseded by Librarian.Description Update in README.md:
"A metadata inventory service that allows you to view, monitor, and analyze all your GCP and Anthos assets across projects and services."to"The Cloud Asset API manages the history and inventory of Google Cloud resources.".maincame from a handwrittenruby_cloud_descriptionoverride in Bazel'sBUILD.bazel.librarian generatederivesruby-cloud-descriptiondirectly fromdocumentation.summaryincloudasset_v1.yaml(PR fix(internal/librarian/ruby): pass documentation summary as ruby-cloud-description option librarian#7105).Product Documentation Link Removal in README.md:
README.mdremoved the sectionSee also the Product Documentation (https://cloud.google.com/asset-inventory/).ruby-cloud-product-url=https://cloud.google.com/asset-inventory/inBUILD.bazel.librarian.yamldoes not passruby-cloud-product-url, nor ispublishing.documentation_uripresent incloudasset_v1.yaml.Copyright Year Update:
2026as expected.Protobuf Comments Update:
proto_docs/google/protobuf/timestamp.rbsource comments updated to reflectprotoc 33.2.Snippet File Permission Normalization:
100755to100644.File & Version Preservation:
keep:(lib/google/cloud/asset/v1/asset_service/helpers.rb,test/google/cloud/asset/v1/additional_paths_test.rb), as well asversion.rb,.repo-metadata.json, andCHANGELOG.md, are correctly preserved during regeneration.Kokoro - Presubmit/Samples failure: